Issue found in DPG modular generation - apiVersion parameter missing #3437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaryGao
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue in DPG modular generation where the apiVersion parameter was missing by correcting the logic for determining required parameters in client parameter generation.
Key changes:
- Restructured the condition logic in
isRequiredfunction to properly handle theapiVersionAsRequiredflag - Moved the apiVersion special case to the beginning of the condition to ensure it takes precedence
- Added a comprehensive test case for Azure Analytics Purview DataMap service to validate the fix
Reviewed Changes
Copilot reviewed 6 out of 48 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/typespec-ts/src/modular/helpers/clientHelpers.ts | Fixed parameter requirement logic to properly handle apiVersionAsRequired flag |
| packages/typespec-test/test/Azure.Analytics.Purview.DataMap/tspconfig.yaml | Added TypeSpec configuration for new test case |
| packages/typespec-test/test/Azure.Analytics.Purview.DataMap/spec/routes.tsp | Added comprehensive route definitions for DataMap service test |
| packages/typespec-test/test/Azure.Analytics.Purview.DataMap/spec/models.tsp | Added model definitions for DataMap service test |
| packages/typespec-test/test/Azure.Analytics.Purview.DataMap/spec/main.tsp | Added main service definition for DataMap test |
| packages/typespec-test/test/Azure.Analytics.Purview.DataMap/spec/client.tsp | Added client customizations for DataMap test |
Member
Author
|
The previous logic was to always return |
v-jiaodi
commented
Oct 31, 2025
packages/typespec-test/test/Azure.Analytics.Purview.DataMap/spec/routes.tsp
Outdated
Show resolved
Hide resolved
MaryGao
reviewed
Nov 4, 2025
MaryGao
reviewed
Nov 4, 2025
packages/typespec-ts/test/modularUnit/scenarios/clientContext/optionalApiVersion.md
Outdated
Show resolved
Hide resolved
Member
|
We offline synced this and we think for Azure services api-version would be a required parameter by convention so we could ignore the optionality definition no matter it is defined in spec side. |
MaryGao
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3438
